Skip to content

Jaro winkler#2041

Merged
onlinejudge95 merged 10 commits into
TheAlgorithms:masterfrom
l3str4nge:jaro_winkler
May 30, 2020
Merged

Jaro winkler#2041
onlinejudge95 merged 10 commits into
TheAlgorithms:masterfrom
l3str4nge:jaro_winkler

Conversation

@l3str4nge

@l3str4nge l3str4nge commented May 27, 2020

Copy link
Copy Markdown
Member

Describe your change:

Added Jaro Winkler algorithm for measuring similarity between two sequences.
https://en.wikipedia.org/wiki/Jaro%E2%80%93Winkler_distance

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

cclauss
cclauss reviewed May 27, 2020
View reviewed changes
Comment thread strings/jaro_winkler.py Outdated
@l3str4nge l3str4nge requested a review from cclauss May 27, 2020 22:39
cclauss
cclauss reviewed May 27, 2020
View reviewed changes
Comment thread strings/jaro_winkler.py Outdated
cclauss
cclauss reviewed May 27, 2020
View reviewed changes
Comment thread strings/jaro_winkler.py Outdated
cclauss
cclauss reviewed May 27, 2020
View reviewed changes
Comment thread strings/jaro_winkler.py Outdated
@l3str4nge l3str4nge requested a review from cclauss May 28, 2020 07:05
poyea
poyea approved these changes May 30, 2020
View reviewed changes

@poyea poyea left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request!🤩

@onlinejudge95 onlinejudge95 merged commit 3357768 into TheAlgorithms:master May 30, 2020
@onlinejudge95 onlinejudge95 mentioned this pull request May 30, 2020
Closed
@cclauss

cclauss commented May 31, 2020

Copy link
Copy Markdown
Member

Please note the formatting changes made by psf/black 32109bd

stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@l3str4nge @poyea @stokhos
Jaro winkler (TheAlgorithms#2041)
5296a66 
* Added jaro_winkler first version

* Added doctests

* Fix flake warnings

* Refactor

* Fixes bug in jaro winkler implementation

* Commit suggestions

* Missing comming suggestions

* Remove unused math module

* Import doctest

Co-authored-by: John Law <johnlaw.po@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclauss cclauss cclauss approved these changes

@poyea poyea poyea approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@l3str4nge @cclauss @poyea @onlinejudge95