Skip to content

fix: reject empty negative binary input - #15689

Open
Yash4305d-y wants to merge 1 commit into
TheAlgorithms:masterfrom
Yash4305d-y:fix/binary-to-decimal-empty-negative
Open

Yash4305d-y wants to merge 1 commit into
TheAlgorithms:masterfrom
Yash4305d-y:fix/binary-to-decimal-empty-negative

Conversation

@Yash4305d-y

Copy link
Copy Markdown

Describe your change

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests?
  • Documentation change?

Bug fixed: bin_to_decimal("-") and bin_to_decimal(" - ") incorrectly returned 0 instead of raising ValueError.

Added validation to reject empty input after removing the optional negative sign, along with two regression doctests.

Checklist

  • I have read [CONTRIBUTING.md](https://github.com/TheAlgorithms/Python/blob/master/CONTRIBUTING.md).
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory. (Not applicable; no new files.)
  • All filenames are in all lowercase characters with no spaces or dashes. (No new filenames.)
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation. (Not applicable; no new algorithm.)
  • If this pull request resolves one or more open issues, then the description above includes the issue number(s) with a closing keyword. (No issue linked.)

@algorithms-keeper algorithms-keeper Bot added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Nov 3, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants