Fix in_static_equilibrium for NumPy 2.x (2-D cross product removed) - #15110
Merged
cclauss merged 1 commit intoAug 28, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
physics/in_static_equilibrium.pycallsnumpy.cross()on 2-D input vectors. NumPy deprecated 2-D cross products in 2.0 and removed them in newer releases, so on recent NumPy the doctest now raises:Current
masterCI still passes only because its lockfile pinsnumpy==2.2.5; the failure surfaces on newer NumPy (e.g. the free-threaded3.14tjob resolvesnumpy==2.5.2). This is a latent break that will hitmasteron the next NumPy bump.The 2-D "cross product" is just the scalar z-component
x·Fy − y·Fxper row, so I compute it directly. Behaviour is identical to the oldcross()and works across all NumPy versions. Doctests and the__main__self-checks pass unchanged.Checklist: