Skip to content

Fix ZeroDivisionError on zero operands in least_common_multiple #14845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CharlesCNorton wants to merge 1 commit into
base: master
Choose a base branch
from
+16 −0
Open

Fix ZeroDivisionError on zero operands in least_common_multiple #14845

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions maths/least_common_multiple.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,15 @@ def least_common_multiple_slow(first_num: int, second_num: int) -> int:
10
>>> least_common_multiple_slow(12, 76)
228
>>> least_common_multiple_slow(0, 5)
0
>>> least_common_multiple_slow(5, 0)
0
>>> least_common_multiple_slow(0, 0)
0
"""
if first_num == 0 or second_num == 0:
return 0
max_num = first_num if first_num >= second_num else second_num
common_mult = max_num
while (common_mult % first_num > 0) or (common_mult % second_num > 0):
Expand All @@ -30,7 +38,15 @@ def least_common_multiple_fast(first_num: int, second_num: int) -> int:
10
>>> least_common_multiple_fast(12,76)
228
>>> least_common_multiple_fast(0, 5)
0
>>> least_common_multiple_fast(5, 0)
0
>>> least_common_multiple_fast(0, 0)
0
"""
if first_num == 0 or second_num == 0:
return 0
return first_num // greatest_common_divisor(first_num, second_num) * second_num


Expand Down