fix: inverted loop condition in chaos_machine.py prevents execution#14777
Open
aeyjeyaryan wants to merge 1 commit into
Open
fix: inverted loop condition in chaos_machine.py prevents execution#14777aeyjeyaryan wants to merge 1 commit into
aeyjeyaryan wants to merge 1 commit into
Conversation
The while loop condition was inverted — it should be . The loop that pulls output data and prompts the user for exit never executed. Also: - Add type hints to all functions - Add module-level docstring with references - Add docstrings with doctests to pull() - Fix reset() to copy K instead of aliasing it (prevented repeated reset) - Remove deprecated in favor of built-in
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Fixes an inverted while-loop condition in
hashes/chaos_machine.pythat prevented the output-pulling loop from ever executing.Checklist:
Summary of changes
Bug fix: The while-loop condition on line 98 was
while inp in ("e", "E"):. Sinceinpis initialized as"", the loop never executed. Changed towhile inp not in ("e", "E"):.Additional improvements:
push,pull,reset)pull()reset()to copyKwithK.copy()instead of aliasing it (buffer_space = K), preventing mutation of the constant initial state on repeatedreset()callstyping.Listwith built-inlistAll checks pass:
ruff,ruff format,mypy, anddoctest.