Skip to content

fix(coordinate_compression): raise exceptions instead of returning -1 #14555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AshrafHosam wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(coordinate_compression): raise exceptions instead of returning -1 #14555

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7801758
fix(coordinate_compression): raise exceptions instead of returning -1
AshrafHosam Apr 14, 2026
cc0b39c
style: assign f-string to variable before raise (ruff EM102)
AshrafHosam Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
style: assign f-string to variable before raise (ruff EM102)
  • Loading branch information
@AshrafHosam
AshrafHosam committed Apr 14, 2026
commit cc0b39cc84e9ead073bf37bd5e84657e5b759020
3 changes: 2 additions & 1 deletion data_compression/coordinate_compression.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,8 @@ def decompress(self, num: int) -> int | float | str:
IndexError: compressed coordinate 5 is out of range
"""
if not 0 <= num < len(self.reverse_map):
raise IndexError(f"compressed coordinate {num} is out of range")
msg = f"compressed coordinate {num} is out of range"
raise IndexError(msg)
return self.reverse_map[num]


Expand Down