Skip to content

feat(other): add grocery store cart model (v3) #14550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nickzerjeski wants to merge 7 commits into from
Closed

feat(other): add grocery store cart model (v3) #14550

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d28896c
feat(other): add grocery store cart model
nickzerjeski Apr 13, 2026
9611435
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 13, 2026
4e7fa49
Fix Ruff EM102 in grocery store cart exceptions
nickzerjeski Apr 13, 2026
eedcb14
Address review feedback for grocery cart edge cases
nickzerjeski Apr 13, 2026
d5e1fb0
Apply suggestions from code review
nickzerjeski Apr 14, 2026
2060085
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 14, 2026
4a679e1
Merge branch 'master' into renew-grocery-store-cart-14050-v2
nickzerjeski Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
  • Loading branch information
@nickzerjeski
nickzerjeski and Copilot authored Apr 14, 2026
commit d5e1fb057c8e6abcb32d3cc64608dc82b494e6e3
37 changes: 33 additions & 4 deletions other/grocery_store_cart.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,32 @@ class GroceryStoreCart:
...
ValueError: quantity must be positive

>>> empty_cart = GroceryStoreCart({"apple": 1.5})
>>> empty_cart.remove_item("apple")
Traceback (most recent call last):
...
KeyError: "'apple' is not present in the cart"

>>> GroceryStoreCart({})
Traceback (most recent call last):
...
ValueError: price_catalog cannot be empty

>>> cart.add_item("bread")
Traceback (most recent call last):
...
KeyError: "'bread' is not in the catalog"

>>> cart.add_item("apple", 0)
Traceback (most recent call last):
...
ValueError: quantity must be positive

>>> cart.remove_item("milk", 0)
Traceback (most recent call last):
...
ValueError: quantity must be positive

>>> empty_cart = GroceryStoreCart({"apple": 1.5})
>>> empty_cart.remove_item("apple")
Traceback (most recent call last):
Expand Down Expand Up @@ -66,14 +92,17 @@ def remove_item(self, item: str, quantity: int = 1) -> None:
raise KeyError(msg)
if quantity > current:
raise ValueError("quantity exceeds amount present in the cart")
if (remaining := current - quantity) > 0:
self.quantities[item] = remaining
else:
if quantity > current:
raise ValueError("quantity exceeds amount present in the cart")
if quantity == current:
self.quantities.pop(item, None)
else:
self.quantities[item] = current - quantity

def total_price(self) -> float:
return sum(
self.price_catalog[item] * qty for item, qty in self.quantities.items()
self.price_catalog[item] * qty
for item, qty in self.quantities.items()
)


Expand Down