Skip to content

added documentation, js standard style and jest testing to kadane algorithm file.#750

Merged
raklaptudirm merged 4 commits into
TheAlgorithms:masterfrom
thisabhijeet:kadanes
Oct 6, 2021
Merged

added documentation, js standard style and jest testing to kadane algorithm file.#750
raklaptudirm merged 4 commits into
TheAlgorithms:masterfrom
thisabhijeet:kadanes

Conversation

@thisabhijeet

Copy link
Copy Markdown
Contributor

Added documentation, js standard style and jest testing to kadane algorithm file.

Welcome to JavaScript community

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Comment thread Dynamic-Programming/KadaneAlgo.js Outdated
Comment thread Dynamic-Programming/KadaneAlgo.js Outdated
Comment thread Dynamic-Programming/tests/KadaneAlgo.test.js Outdated
Comment thread Dynamic-Programming/tests/KadaneAlgo.test.js Outdated
@raklaptudirm raklaptudirm added algorithm Adds or improves an algorithm feature Adds a new feature ESM required Convert code to ECMAScript Modules (ESM) Reviewed labels Oct 6, 2021
@thisabhijeet

Copy link
Copy Markdown
Contributor Author

import { kadaneAlgo } from '../KadaneAlgo' :- i have used this in the test file. Not using 'keyword' was creating an error

@raklaptudirm

Copy link
Copy Markdown
Member

Please fix your tests

@raklaptudirm raklaptudirm removed the ESM required Convert code to ECMAScript Modules (ESM) label Oct 6, 2021
@raklaptudirm raklaptudirm merged commit 6eeb989 into TheAlgorithms:master Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

algorithm Adds or improves an algorithm feature Adds a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants