tests: only test changed packages - #1194
Conversation
appgurueu
left a comment
There was a problem hiding this comment.
This is akin to outcommenting the test.
Project Euler solutions can be expected to take some time (should be < one minute though, ideally the algo should be optimized).
If you do not want to run this test, simply exclude the directory when running tests using Jest.
|
However, having this long-running tests clogs up everyone's workflow and not "just" the CI, therefore I recommend to not just uncommenting the test but rather explicitly skipping it. This way, it's still visible in the console. Finding a solution to the runtime behavior is step 2 - but meanwhile, everyone else can continue working without that delay. What do you think? |
|
We'll have to leave the issue open to find a proper fix eventually however. |
|
Yup! 👍 I mereley mentioned the issue no. in the commit message but didn't close it. |
|
Ideally, we would want to run the tests in the changed directories only. |
|
Jest has an |
|
That could be great! |
|
@raklaptudirm I've updated the CI config, as well 👍 |
appgurueu
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
|
The pr looks fine, but I had an idea. I think we would want to run all the tests in the master branch, but run tests on only the changed files in the prs. What do you all think? |
|
I guess I could set that up with GitHub Actions, yeah. But as long as #1193 is not solved, the |
|
I've updated the Workflow accordingly - please take a look 😀 |
The master build should not be an issue as no one will need to wait for that to complete. |
Relates to #1193