[OTHER]: Duplicate entry of sieve of eratosthenes

What would you like to share?

There's three entries in total for Sieve of Eratosthenes on the website, but the problem is that there's a primary one out of the three which has a majority of the implementations, including that of JS. However, there's another one which has just another JS implementation of the exact same thing, and it's named Sieve of Eratosthenes Int Array, which is both a weird name and just a random duplicate entry. Since it only had a JS entry, I wasn't sure if I should open an issue on the website repo or here, hence I thought as this was a JS repo issue I'd open it here.
So, do we remove the duplicate entry from the repository?

Additional information

No response

I think we can get rid of https://github.com/TheAlgorithms/JavaScript/blob/master/Maths/SieveOfEratosthenesIntArray.js; it is strictly inferior to https://github.com/TheAlgorithms/JavaScript/blob/master/Maths/SieveOfEratosthenes.js (except perhaps for being a bit simpler, at the cost of being less optimized).

Since you've added the beginner-friendly tag, do you wish to keep this issue open for any beginners to take it up or should I do it now and push the changes? (considering we only need to remove certain files)

Since you've added the beginner-friendly tag, do you wish to keep this issue open for any beginners to take it up or should I do it now and push the changes? (considering we only need to remove certain files)

Feel free to do it now

FIXES: TheAlgorithms#1666 , remove references to SieveOfEratosthenesI…

There are three entries for the Sieve of Eratosthenes on the website, with one primary entry containing most implementations, including JavaScript. However, there's another entry named "Sieve of Eratosthenes Int Array," which is a duplicate with only a JavaScript implementation and a confusing name.

Remove the "Sieve of Eratosthenes Int Array" entry to avoid confusion and maintain consistency.
Ensure no unique features or references are lost in the process.

Please review and confirm if this is a suitable approach.

There are two Sieve of Eratosthenes entries in the website ( I think they are duplicate ). It returns an array of boolean which tells the numbers are true or false.

There is another one Sieve of Eratosthenes Int Array it return the Array of numbers that are primes only and it doesn't contains any non prime numbers.

I think Sieve of Eratosthenes Int Array should not be removed, while out of two Sieve of Eratosthenes entries one should be removed because I think they are duplicate.
Please tell if I am in right direction.

As I said, I think removing the "Int Array" variant is fine. Then there is only one Sieve of Eratosthenes left.

There is a pr with the necessary change, but they seem to have abandoned it without removing the related tests.

is this issue still on??

Yes.

Sounds good!
I agree with removing one of the implementations and renaming the remaining one to "Sieve of Eratosthenes" for clarity. I'll go ahead and:
->Remove the boolean array implementation.
->Rename the int array version to simply "Sieve of Eratosthenes."
->Consolidate the tests to ensure everything works smoothly.
I'll start working on this and submit a PR shortly. Let me know if there's anything else you'd like to add!?

Fixes TheAlgorithms#1666: Remove duplicate entry of Sieve of Eratosth…

I would love to contribute in this , if it open, it is my first time , can you please guide me.

Hi if this is still open maybe I could work on it. I am a beginner.

Hey is this still available?

Hey!! please assign this to me if it's still available.

Hi I like to work with this. Is it still open to work

Hii, If they issue is still open i would like to work on this. Could you please assign me so that i can work on it

Hi,this wasn't assigned to me either.

…

On Fri, 3 Jan 2025 at 09:38, AtmajMishra ***@***.***> wrote: Hii, If they issue is still open i would like to work on this. Could you please assign me so that i can work on it — Reply to this email directly, view it on GitHub <#1666 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BCMPMJTOKVRM4LUD6NEI54T2IYENBAVCNFSM6AAAAABIEN5A46VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRYGY3DSNJXG4> . You are receiving this because you commented.Message ID: ***@***.***>

This issue won't be assigned to anyone, open a pull request and it will be reviewed.

Remove the boolean array implementation.

Rename the int array version to simply "Sieve of Eratosthenes."

Consolidate the tests to ensure everything works smoothly.

FIXES: TheAlgorithms#1666 and conform to alg comment standards

Resolve duplicate entries for sieve of eratosthenes (TheAlgorithms#1770)

Navigation Menu

Repository navigation

[OTHER]: Duplicate entry of sieve of eratosthenes #1666

What would you like to share?

Additional information

5 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[OTHER]: Duplicate entry of sieve of eratosthenes #1666

Description

What would you like to share?

Additional information

Activity

appgurueu commented on May 23, 2024

SpiderMath commented on May 23, 2024

appgurueu commented on May 23, 2024

AbhishekMane06 commented on Jul 12, 2024

PranjalShrivas commented on Jul 14, 2024

appgurueu commented on Jul 17, 2024

raklaptudirm commented on Jul 18, 2024

shah0108 commented on Oct 1, 2024

appgurueu commented on Oct 2, 2024

5 remaining items

shah0108 commented on Oct 5, 2024

sanjogbhalla16 commented on Oct 8, 2024

aynaash commented on Oct 8, 2024

m3tal10 commented on Oct 10, 2024

AishwaryaTatiwar commented on Oct 13, 2024

mayurshetty15 commented on Dec 13, 2024

AtmajMishra commented on Jan 3, 2025

AishwaryaTatiwar commented on Jan 3, 2025

raklaptudirm commented on Jan 3, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions