Added DepthFirstSearch.java and DepthFirstTestSearch.java#737
Merged
Conversation
this test is created for the DepthFirstSearch.java file- that I added- containing the DepthFirstSearch algorithm
yanglbme
requested changes
May 10, 2019
Update DepthFirstSearch.java - signature removed, and whitespaces resolved Co-Authored-By: Libin Yang <contact@yanglibin.info>
yanglbme
approved these changes
May 11, 2019
yanglbme
reviewed
May 11, 2019
| import org.junit.Assert; | ||
| import org.junit.Test; | ||
| import src.main.java.com.search.DepthFirstSearch; | ||
| import src.main.java.com.search.BinaryTree; |
Member
There was a problem hiding this comment.
'src.main.java.com.search.BinaryTree' is not public in 'src.main.java.com.search'. Cannot be accessed from outside package.
| Assert.assertEquals("Incorrect index", null, DepthFirstSearch.find(8, tree1)); | ||
| Assert.assertEquals("Incorrect index", null, DepthFirstSearch.find(-2, tree1)); | ||
|
|
||
| BinaryTree<String> tree2 = new BinaryTree<String>(); |
Member
There was a problem hiding this comment.
Suggested change
| BinaryTree<String> tree2 = new BinaryTree<String>(); | |
| BinaryTree<String> tree2 = new BinaryTree<>(); |
| @Test | ||
| public void testDepthFirstSearch() { | ||
|
|
||
| BinaryTree<Integer> tree1 = new BinaryTree<Integer>(); |
Member
There was a problem hiding this comment.
Suggested change
| BinaryTree<Integer> tree1 = new BinaryTree<Integer>(); | |
| BinaryTree<Integer> tree1 = new BinaryTree<>(); |
Member
|
Hi @abircb, I've revert the PR You can open a new pull request after fixing the problems. |
Author
|
Hi @yanglbme, I've just opened a new pull request- please check it out. And thanks for all the valuable feedback :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented the DepthFirstSearch in Java by creating a Binary Tree class and adding appropriate 'add' and 'get' methods. Also added a JUnit test :)