Skip to content

#708 (bugfix for fibonacci sequence function) #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yanglbme merged 1 commit into from
Feb 27, 2019
+8 −8
Merged

#708 (bugfix for fibonacci sequence function) #709

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions Dynamic Programming/Fibonacci.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,9 @@ public static void main(String[] args) throws Exception {
BufferedReader br = new BufferedReader(new InputStreamReader(System.in));
int n = Integer.parseInt(br.readLine());

System.out.println(fibMemo(n)); // Returns 8 for n = 6
System.out.println(fibBotUp(n)); // Returns 8 for n = 6
// Methods all returning [0, 1, 1, 2, 3, 5, ...] for n = [0, 1, 2, 3, 4, 5, ...]
System.out.println(fibMemo(n));
System.out.println(fibBotUp(n));
}

/**
Expand All @@ -34,13 +35,12 @@ private static int fibMemo(int n) {

int f;

if (n <= 2) {
f = 1;
if (n <= 1) {
f = n;
} else {
f = fibMemo(n - 1) + fibMemo(n - 2);
map.put(n, f);
}

return f;
}

Expand All @@ -54,10 +54,10 @@ private static int fibBotUp(int n) {

Map<Integer, Integer> fib = new HashMap<>();

for (int i = 1; i < n + 1; i++) {
for (int i = 0; i <= n; i++) {
Comment thread
cchexcode marked this conversation as resolved.
int f;
if (i <= 2) {
f = 1;
if (i <= 1) {
f = i;
} else {
f = fib.get(i - 1) + fib.get(i - 2);
}
Expand Down