Skip to content

adding the fibonacci series to the Recursion package#6079

Merged
siriak merged 6 commits into
TheAlgorithms:masterfrom
MohamedBoukthir:fibonacciSeries
Nov 2, 2024
Merged

adding the fibonacci series to the Recursion package#6079
siriak merged 6 commits into
TheAlgorithms:masterfrom
MohamedBoukthir:fibonacciSeries

Conversation

@MohamedBoukthir

@MohamedBoukthir MohamedBoukthir commented Nov 1, 2024

Copy link
Copy Markdown
Contributor
  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter

codecov-commenter commented Nov 1, 2024

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.46%. Comparing base (df0c997) to head (123f683).
⚠️ Report is 523 commits behind head on master.

Files with missing lines Patch % Lines
...a/com/thealgorithms/Recursion/FibonacciSeries.java 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #6079   +/-   ##
=========================================
  Coverage     73.46%   73.46%           
- Complexity     5096     5099    +3     
=========================================
  Files           657      658    +1     
  Lines         17632    17637    +5     
  Branches       3394     3394           
=========================================
+ Hits          12953    12957    +4     
- Misses         4176     4178    +2     
+ Partials        503      502    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@siriak siriak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add JUnit tests, remove main, and fix PR checks

@siriak siriak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak merged commit 539871a into TheAlgorithms:master Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants