Skip to content

Add tests for A5KeyStreamGenerator.java, improve documentation#5595

Merged
siriak merged 6 commits into
TheAlgorithms:masterfrom
Hardvan:a5keystream_add_tests
Oct 7, 2024
Merged

Add tests for A5KeyStreamGenerator.java, improve documentation#5595
siriak merged 6 commits into
TheAlgorithms:masterfrom
Hardvan:a5keystream_add_tests

Conversation

@Hardvan

@Hardvan Hardvan commented Oct 6, 2024

Copy link
Copy Markdown
Contributor
  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter

codecov-commenter commented Oct 6, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.79%. Comparing base (cacd23a) to head (8896801).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5595      +/-   ##
============================================
+ Coverage     56.50%   56.79%   +0.28%     
- Complexity     3580     3599      +19     
============================================
  Files           545      545              
  Lines         15722    15723       +1     
  Branches       2995     2995              
============================================
+ Hits           8884     8930      +46     
+ Misses         6463     6415      -48     
- Partials        375      378       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hardvan Hardvan marked this pull request as ready for review October 6, 2024 05:29

@siriak siriak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak enabled auto-merge (squash) October 7, 2024 14:20
@siriak siriak merged commit 93cfa86 into TheAlgorithms:master Oct 7, 2024
@Hardvan

Hardvan commented Oct 7, 2024

Copy link
Copy Markdown
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants