style: use getOrDefault in MajorityElement#5454
Merged
alxkm merged 1 commit intoTheAlgorithms:masterfrom Sep 18, 2024
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5454 +/- ##
============================================
- Coverage 52.03% 52.03% -0.01%
+ Complexity 3238 3237 -1
============================================
Files 524 524
Lines 15181 15179 -2
Branches 2888 2887 -1
============================================
- Hits 7900 7898 -2
Misses 6956 6956
Partials 325 325 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alxkm
reviewed
Sep 18, 2024
alxkm
approved these changes
Sep 18, 2024
This was referenced Sep 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simplifies the logic inside the
majoritymethod.The background story is that I was experimenting with
inferand it was reporting a potential Null dereference (there are about 29 left). In this case it will not happen, but the code can be written better (as in this PR). I am considering including infer into our CI. I will keep you updated.clang-format -i --style=file path/to/your/file.java