Skip to content

refactor: cleanup RadixSort - #5280

Merged
vil02 merged 17 commits into
TheAlgorithms:masterfrom
alxkm:refactor/radix_sort
Jul 19, 2024
Merged

vil02 merged 17 commits into
TheAlgorithms:masterfrom
alxkm:refactor/radix_sort

Conversation

@alxkm

@alxkm alxkm commented Jul 9, 2024 •

Copy link
Copy Markdown
Member

Cleanup RadixSort

Adding test

Update DIRECTORY.md

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter

codecov-commenter commented Jul 9, 2024 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@f1e2606). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #5280   +/-   ##
=========================================
  Coverage          ?   40.88%           
  Complexity        ?     2520           
=========================================
  Files             ?      519           
  Lines             ?    15452           
  Branches          ?     2945           
=========================================
  Hits              ?     6318           
  Misses            ?     8840           
  Partials          ?      294           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread src/main/java/com/thealgorithms/sorts/RadixSort.java Outdated
Comment thread src/main/java/com/thealgorithms/sorts/RadixSort.java Outdated
Comment thread src/main/java/com/thealgorithms/sorts/RadixSort.java
Comment thread src/main/java/com/thealgorithms/sorts/RadixSort.java Outdated
Comment thread src/main/java/com/thealgorithms/sorts/RadixSort.java
Comment thread src/test/java/com/thealgorithms/sorts/RadixSortTest.java Outdated
@alxkm
alxkm requested a review from vil02 July 15, 2024 18:24
@alxkm

alxkm commented Jul 19, 2024

Copy link
Copy Markdown
Member Author

Hello @vil02, all issues for this PR already fixed (also including negative numbers logic remove), could you please review this PR. Thanks.

Comment thread src/main/java/com/thealgorithms/sorts/RadixSort.java Outdated
Comment thread src/main/java/com/thealgorithms/sorts/RadixSort.java Outdated
Comment thread src/main/java/com/thealgorithms/sorts/RadixSort.java Outdated
Comment thread src/main/java/com/thealgorithms/sorts/RadixSort.java Outdated
Comment thread src/main/java/com/thealgorithms/sorts/RadixSort.java Outdated
Comment thread src/main/java/com/thealgorithms/sorts/RadixSort.java Outdated
@alxkm
alxkm requested a review from vil02 July 19, 2024 16:10
@vil02
vil02 merged commit 9403214 into TheAlgorithms:master Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants