Skip to content

style: include RV_ABSOLUTE_VALUE_OF_HASHCODE #5273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
siriak merged 1 commit into from
Jul 2, 2024
Merged

style: include RV_ABSOLUTE_VALUE_OF_HASHCODE #5273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
style: include RV_ABSOLUTE_VALUE_OF_HASHCODE
  • Loading branch information
@vil02
vil02 committed Jul 2, 2024
commit 7d7e8f962f7afef1d65efdd8411a9cac888f3dc7
3 changes: 0 additions & 3 deletions spotbugs-exclude.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,6 @@
<Match>
<Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE" />
</Match>
<Match>
<Bug pattern="RV_ABSOLUTE_VALUE_OF_HASHCODE" />
</Match>
<!-- fb-contrib -->
<Match>
<Bug pattern="OCP_OVERLY_CONCRETE_PARAMETER" />
Expand Down
3 changes: 1 addition & 2 deletions src/main/java/com/thealgorithms/datastructures/hashmap/hashing/GenericHashMapUsingArray.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,7 @@ public void put(K key, V value) {

// tells which bucket to go to
private int hashFunction(K key) {
int hc = key.hashCode();
return Math.abs(hc) % buckets.length;
return Math.floorMod(key.hashCode(), buckets.length);
}

private void reHash() {
Expand Down