Repository navigation
Refactor: Replace Swap and Comparison Methods with SortUtils Utility Methods - #5246
Merged
Merged
Conversation
alxkm
requested review from
BamaCharanChhandogi,
vil02 and
yanglbme
as code owners
June 22, 2024 12:20
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5246 +/- ##
============================================
- Coverage 39.71% 39.70% -0.02%
+ Complexity 2433 2430 -3
============================================
Files 517 517
Lines 15496 15492 -4
Branches 2958 2958
============================================
- Hits 6155 6151 -4
Misses 9052 9052
Partials 289 289 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vil02
approved these changes
Jun 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HeapSort class had duplicated methods for less and swap, which already exist in SortUtils.
It is better to use the common methods instead of the old ones.
This pull request also includes some renaming for clarity.
clang-format -i --style=file path/to/your/file.java