Adding class for generating all subsequences from a given List - #5194
Merged
Conversation
alxkm
requested review from
BamaCharanChhandogi,
vil02 and
yanglbme
as code owners
May 29, 2024 17:04
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5194 +/- ##
============================================
+ Coverage 38.63% 38.69% +0.05%
- Complexity 2379 2383 +4
============================================
Files 516 517 +1
Lines 15388 15403 +15
Branches 2957 2958 +1
============================================
+ Hits 5945 5960 +15
Misses 9158 9158
Partials 285 285 ☔ View full report in Codecov by Sentry. |
Member
|
I like the fact that your code is generic. |
vil02
requested changes
May 29, 2024
…arametrized test. Fixed input parameter as final.
vil02
requested changes
May 30, 2024
vil02
left a comment
Member
There was a problem hiding this comment.
The code looks good. I made few renaming suggestions.
added 2 commits
May 30, 2024 16:14
Renaming test method. Adding duplication test. Renaming TestData to TestCase.
vil02
reviewed
May 30, 2024
vil02
enabled auto-merge (squash)
May 30, 2024 18:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clang-format -i --style=file path/to/your/file.java