enabled TypeName.#5192
Closed
SAIVARDHAN15 wants to merge 2 commits intoTheAlgorithms:masterfrom
SAIVARDHAN15:master
Closed
enabled TypeName.#5192SAIVARDHAN15 wants to merge 2 commits intoTheAlgorithms:masterfrom SAIVARDHAN15:master
SAIVARDHAN15 wants to merge 2 commits intoTheAlgorithms:masterfrom
SAIVARDHAN15:master
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5192 +/- ##
============================================
+ Coverage 38.56% 38.64% +0.07%
- Complexity 2378 2379 +1
============================================
Files 516 516
Lines 15313 15388 +75
Branches 2957 2957
============================================
+ Hits 5906 5947 +41
- Misses 9121 9157 +36
+ Partials 286 284 -2 ☔ View full report in Codecov by Sentry. |
vil02
requested changes
May 29, 2024
Member
vil02
left a comment
There was a problem hiding this comment.
Please rename all of the types, which need that.
| @@ -117,7 +117,10 @@ | |||
| <!-- TODO <module name="ParameterName"/> --> | |||
| <module name="StaticVariableName"/> | |||
| <!-- TODO <module name="TypeName"/> --> | |||
Member
There was a problem hiding this comment.
Suggested change
| <!-- TODO <module name="TypeName"/> --> | |
| <module name="TypeName"/> |
Comment on lines
+120
to
+123
| <module name="TypeName"> | ||
| <property name="format" value="^[A-Z][a-zA-Z0-9]*$"/> | ||
| <property name="severity" value="warning"/> | ||
| </module> |
Member
There was a problem hiding this comment.
Suggested change
| <module name="TypeName"> | |
| <property name="format" value="^[A-Z][a-zA-Z0-9]*$"/> | |
| <property name="severity" value="warning"/> | |
| </module> |
Member
|
Done in #5214. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clang-format -i --style=file path/to/your/file.java