Skip to content

style: enable EqualsHashCode in checkstyle#5157

Merged
vil02 merged 1 commit intoTheAlgorithms:masterfrom
CodaBlurd:enable_EqualsHashCode
May 12, 2024
Merged

style: enable EqualsHashCode in checkstyle#5157
vil02 merged 1 commit intoTheAlgorithms:masterfrom
CodaBlurd:enable_EqualsHashCode

Conversation

@CodaBlurd
Copy link
Copy Markdown
Contributor

@CodaBlurd CodaBlurd commented May 12, 2024 •
edited by vil02
Loading

Related to #5119.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 12, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 38.24%. Comparing base (319d514) to head (1fa0c94).
Report is 327 commits behind head on master.

Files with missing lines Patch % Lines
...com/thealgorithms/datastructures/trees/KDTree.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #5157      +/-   ##
============================================
- Coverage     38.25%   38.24%   -0.01%     
+ Complexity     2362     2361       -1     
============================================
  Files           516      516              
  Lines         15304    15305       +1     
  Branches       2957     2957              
============================================
- Hits           5854     5853       -1     
- Misses         9164     9165       +1     
- Partials        286      287       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vil02 vil02 force-pushed the enable_EqualsHashCode branch from fedecd4 to 1fa0c94 Compare May 12, 2024 09:27
@vil02
Copy link
Copy Markdown
Member

vil02 commented May 12, 2024

Thanks!

I have two remarks:

  • if you want to reference an issue or another PR (from the same repository) do it by writing # followed by its number,
  • it seems to me that the method equals could be simplified to the form:
        @Override
        public boolean equals(Object obj) {
            if (obj instanceof Point other) {
                return Arrays.equals(other.coordinates, this.coordinates);
            }
            return false;
        }

Would you like to open another PR doing that?

@vil02 vil02 merged commit 5703be5 into TheAlgorithms:master May 12, 2024
@vil02 vil02 mentioned this pull request May 12, 2024
Closed
26 tasks
@CodaBlurd
Copy link
Copy Markdown
Contributor Author

CodaBlurd commented May 12, 2024

Yes I will open another PR with the recommended changes. Thank you!

This was referenced May 12, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vil02 vil02 vil02 approved these changes

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

@BamaCharanChhandogi BamaCharanChhandogi Awaiting requested review from BamaCharanChhandogi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CodaBlurd @codecov-commenter @vil02