chore: configure checkstyle#5110
Merged
siriak merged 1 commit intoTheAlgorithms:masterfrom Apr 24, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5110 +/- ##
=========================================
Coverage 37.23% 37.23%
Complexity 2343 2343
=========================================
Files 517 517
Lines 15630 15630
Branches 2975 2975
=========================================
Hits 5820 5820
Misses 9522 9522
Partials 288 288 ☔ View full report in Codecov by Sentry. |
This was referenced Apr 25, 2024
6 tasks
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
checkstyleto this project. Thecheckstyle.xmlis derived from sun_checks.xml by commenting out some some of the rules - they are marked byTODO. I think it might be a good idea to introduce some of them in the future. I will create an issue, where one can discuss which rules should be enabled.The
build.ymlwill fail if any warning would be found.At the moment there is some unused import in one of the tests.Fixed in #5113.@siriak what is your opinion?
clang-format -i --style=file path/to/your/file.java