Skip to content

Cleanup SumOfDigits and its tests - #4994

Merged
siriak merged 1 commit into
TheAlgorithms:masterfrom
vil02:cleanup_sum_of_digits
Jan 5, 2024
Merged

Cleanup SumOfDigits and its tests#4994
siriak merged 1 commit into
TheAlgorithms:masterfrom
vil02:cleanup_sum_of_digits

Conversation

@vil02

@vil02 vil02 commented Jan 4, 2024

Copy link
Copy Markdown
Member

This PR is a pretty straightforward cleanup of the SumOfDigits, namely it:

  • uses Math.abs,
  • makes sumOfDigitsFast more functional,
  • rewrites tests as parameterized test.
  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@vil02
vil02 marked this pull request as ready for review January 4, 2024 15:54

@siriak siriak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak
siriak merged commit 8930ab5 into TheAlgorithms:master Jan 5, 2024
@vil02
vil02 deleted the cleanup_sum_of_digits branch January 5, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants