Skip to content

Added [FEATURE REQUEST] Golden Ration formula to find Nth Fibonacci number #4505 - #4513

Merged
vil02 merged 142 commits into
TheAlgorithms:masterfrom
debnath003:master
Oct 13, 2023
Merged

Added [FEATURE REQUEST] Golden Ration formula to find Nth Fibonacci number #4505#4513
vil02 merged 142 commits into
TheAlgorithms:masterfrom
debnath003:master

Conversation

@debnath003

@debnath003 debnath003 commented Oct 1, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.

@debnath003

debnath003 commented Oct 1, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@debasishbsws @BamaCharanChhandogi can you check the code that I have given about the golden ratio of Fibonacci Number and approve the PR?

@debnath003

debnath003 commented Oct 2, 2023

Copy link
Copy Markdown
Contributor Author

@debasishbsws I have given the code, awaiting your review

@debnath003

debnath003 commented Oct 2, 2023

Copy link
Copy Markdown
Contributor Author

@debasishbsws Awaiting your review, I have given the code much earlier

@debnath003 debnath003 mentioned this pull request Oct 2, 2023
Closed
@debnath003

debnath003 commented Oct 2, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@debasishbsws @BamaCharanChhandogi @yanglbme @vil02 awaiting review for my PR

@debnath003

debnath003 commented Oct 3, 2023

Copy link
Copy Markdown
Contributor Author

@debasishbsws @BamaCharanChhandogi @yanglbme @vil02 Someone please approve my PR, I have given this PR 2 days ago!

@debnath003

debnath003 commented Oct 3, 2023

Copy link
Copy Markdown
Contributor Author

@BamaCharanChhandogi @debasishbsws please check my PR, awaiting review

vil02
vil02 requested changes Oct 7, 2023
View reviewed changes
Comment thread src/main/java/com/thealgorithms/maths/FibonacciNumber.java Outdated
Comment thread src/main/java/com/thealgorithms/maths/FibonacciNumber.java Outdated
Comment thread src/main/java/com/thealgorithms/maths/FibonacciNumber.java Outdated
Comment thread src/main/java/com/thealgorithms/maths/FibonacciNumber.java Outdated
debnath003 and others added 4 commits October 7, 2023 23:48
@debnath003 @vil02
Update src/main/java/com/thealgorithms/maths/FibonacciNumber.java
10b4020 
Co-authored-by: Piotr Idzik <65706193+vil02@users.noreply.github.com>
@debnath003 @vil02
Update src/main/java/com/thealgorithms/maths/FibonacciNumber.java
9b591dc 
Co-authored-by: Piotr Idzik <65706193+vil02@users.noreply.github.com>
@debnath003
Update FibonacciNumber.java
83b6fd0
@debnath003
Merge branch 'master' into master
5fd14ae
@debnath003
debnath003 requested a review from vil02 October 7, 2023 18:36
@debnath003

debnath003 commented Oct 7, 2023

Copy link
Copy Markdown
Contributor Author

@vil02 can you please review this once again? Waiting for the PR and approving review!

@vil02

vil02 commented Oct 8, 2023

Copy link
Copy Markdown
Member

@debnath003 as mentioned earlier: please add tests.

@debnath003

debnath003 commented Oct 13, 2023

Copy link
Copy Markdown
Contributor Author

Everything is done @vil02 , I thought that compute would have some method overriding, so I rewrote nthFibonaccicompute and calFibcompute,

Also, gave the documentation of the two main files! Now please check the codes @vil02 and approve the PR!

@debnath003
debnath003 requested a review from vil02 October 13, 2023 15:43
vil02
vil02 requested changes Oct 13, 2023
View reviewed changes
Comment thread src/main/java/com/thealgorithms/maths/Fibonacci.java Outdated
Comment thread src/main/java/com/thealgorithms/maths/Fibonacci.java Outdated
Comment thread src/main/java/com/thealgorithms/maths/FibonacciNumberGoldenRation.java Outdated
@debnath003
debnath003 requested a review from vil02 October 13, 2023 19:16
@debnath003

debnath003 commented Oct 13, 2023

Copy link
Copy Markdown
Contributor Author

@vil02 all done! Please review this again!

vil02
vil02 reviewed Oct 13, 2023
View reviewed changes
Comment thread src/main/java/com/thealgorithms/maths/FibonacciNumberGoldenRation.java Outdated
@debnath003
debnath003 requested a review from vil02 October 13, 2023 19:20
@vil02

vil02 commented Oct 13, 2023

Copy link
Copy Markdown
Member

@debnath003 this was a long one. But very interesting: it is great to know that 71 is the smallest number for which golden ratio formula will give an incorrect result due to floating points arithmetic issues for double.

Thanks for your contribution!

@vil02
vil02 merged commit 24a8223 into TheAlgorithms:master Oct 13, 2023
@debnath003

debnath003 commented Oct 13, 2023

Copy link
Copy Markdown
Contributor Author

@debnath003 this was a long one. But very interesting: it is great to know that 71 is the smallest number for which golden ratio formula will give an incorrect result due to floating points arithmetic issues for double.

Thanks for your contribution!

This has been one of the most hectic PR commits I have ever done, thanks for constantly guiding me @vil02 !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vil02 vil02 vil02 approved these changes
@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner
@debasishbsws debasishbsws Awaiting requested review from debasishbsws
@BamaCharanChhandogi BamaCharanChhandogi Awaiting requested review from BamaCharanChhandogi

Assignees

@vil02 vil02

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@debnath003 @vil02