#4358 Fix : Floodfill infinite recursion due to same color - #4359
Merged
Conversation
Manan-09
requested review from
BamaCharanChhandogi,
debasishbsws,
siriak,
vil02 and
yanglbme
as code owners
September 9, 2023 12:38
Manan-09
force-pushed
the
#4358
branch
2 times, most recently
from
September 9, 2023 12:44
dd33754 to
0af9c13
Compare
vil02
approved these changes
Sep 9, 2023
vil02
left a comment
Member
There was a problem hiding this comment.
Looks good.
There are few changes changes in the remaining pieces of this file, but I cannot suggest them here. I will make a suitable PR afterward.
Contributor
Author
|
Thanks @vil02 , |
Member
|
@Manan-09 this was my first merge as a maintainer of this repository! Enjoy further contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #4358
Fixed case when both newColor and oldColor is passed as same integer causing infinite recursion by adding extra base condition.
Also added testcase for same and after that ran all testcase, which resulted as all passed.