Skip to content

tests: add tests for GenericRoot #4276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
siriak merged 5 commits into from
Aug 3, 2023
Merged

tests: add tests for GenericRoot #4276

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7eb4d88
tests: add `GenericRootTest`
vil02 Jul 31, 2023
3531ea1
fix: handle negative inputs
vil02 Jul 31, 2023
6ec1b90
refactor: simplify `genericRoot` by using recursion
vil02 Jul 31, 2023
12fbb33
refactor: make`GenericRoot` a proper utility class
vil02 Jul 31, 2023
fec00bf
style: add `base`, mark input args as `final`
vil02 Jul 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
style: add base, mark input args as final
  • Loading branch information
@vil02
vil02 committed Jul 31, 2023
commit fec00bf02e33961b77108e86a47c1d78c570253d
12 changes: 7 additions & 5 deletions src/main/java/com/thealgorithms/maths/GenericRoot.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,19 +8,21 @@ public final class GenericRoot {
private GenericRoot() {
}

private static int sumOfDigits(int n) {
private static int base = 10;

private static int sumOfDigits(final int n) {
assert n >= 0;
if (n < 10) {
if (n < base) {
return n;
}
return n % 10 + sumOfDigits(n / 10);
return n % base + sumOfDigits(n / base);
}

public static int genericRoot(int n) {
public static int genericRoot(final int n) {
if (n < 0) {
return genericRoot(-n);
}
if (n > 10) {
if (n > base) {
return genericRoot(sumOfDigits(n));
}
return n;
Expand Down