Skip to content

surfaceAreaTriangle(fn_name_modified) - #4220

Merged
siriak merged 3 commits into
TheAlgorithms:masterfrom
THIRU-1074:master
Jun 23, 2023
Merged

surfaceAreaTriangle(fn_name_modified)#4220
siriak merged 3 commits into
TheAlgorithms:masterfrom
THIRU-1074:master

Conversation

@THIRU-1074

Copy link
Copy Markdown
Contributor

---changing the function's identifier from surfaceAreaTriangleRectangle to surfaceAreaTriangle.

@siriak siriak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update tests

@THIRU-1074

Copy link
Copy Markdown
Contributor Author

Please also update tests

Yeah I have modified and commited.

@siriak

siriak commented Jun 23, 2023

Copy link
Copy Markdown
Member

Please see build logs, there are some errors Error: COMPILATION ERROR :
[INFO] -------------------------------------------------------------
Error: /home/runner/work/Java/Java/src/test/java/com/thealgorithms/maths/AreaTest.java:[39,32] cannot find symbol
symbol: method surfaceAreaTriangleRectangle(int,int)
location: class com.thealgorithms.maths.Area
Error: /home/runner/work/Java/Java/src/test/java/com/thealgorithms/maths/AreaTest.java:[84,75] cannot find symbol
symbol: method surfaceAreaTriangleRectangle(int,int)
location: class com.thealgorithms.maths.Area
Error: /home/runner/work/Java/Java/src/test/java/com/thealgorithms/maths/AreaTest.java:[86,75] cannot find symbol
symbol: method surfaceAreaTriangleRectangle(int,int)
location: class com.thealgorithms.maths.Area

@THIRU-1074

Copy link
Copy Markdown
Contributor Author

Please see build logs, there are some errors Error: COMPILATION ERROR : [INFO] ------------------------------------------------------------- Error: /home/runner/work/Java/Java/src/test/java/com/thealgorithms/maths/AreaTest.java:[39,32] cannot find symbol symbol: method surfaceAreaTriangleRectangle(int,int) location: class com.thealgorithms.maths.Area Error: /home/runner/work/Java/Java/src/test/java/com/thealgorithms/maths/AreaTest.java:[84,75] cannot find symbol symbol: method surfaceAreaTriangleRectangle(int,int) location: class com.thealgorithms.maths.Area Error: /home/runner/work/Java/Java/src/test/java/com/thealgorithms/maths/AreaTest.java:[86,75] cannot find symbol symbol: method surfaceAreaTriangleRectangle(int,int) location: class com.thealgorithms.maths.Area

Thank you ! Siriak for guiding me ...Now all the checks have passed.

@siriak siriak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak
siriak merged commit 05ca93e into TheAlgorithms:master Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants