Skip to content

Reduce Redundancy: Remove unnecessary code#4141

Merged
yanglbme merged 12 commits into
TheAlgorithms:masterfrom
saurabh-rahate:reduce-redundancy
Apr 3, 2023
Merged

Reduce Redundancy: Remove unnecessary code#4141
yanglbme merged 12 commits into
TheAlgorithms:masterfrom
saurabh-rahate:reduce-redundancy

Conversation

@saurabh-rahate
Copy link
Copy Markdown
Contributor

@saurabh-rahate saurabh-rahate commented Apr 2, 2023

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.

This PR contains:

  1. Removal of unnecessary String conversions
  2. Removal of pointless boolean expressions
  3. Simplification of conditional statements
  4. Removal of redundant variables (variables that don't have any special meaning/ context while execution)
  5. Removal of duplicate condition
  6. Removal of unnecessary while loop
  7. Removal of manual Min/Max calculation
  8. Removal of unnecessary return statements
  9. Removal of unnecessary call to String.format()
  10. Removal of unnecessary type cast
  11. Removal of unnecessary wrapping of primitives

@saurabh-rahate
Copy link
Copy Markdown
Contributor Author

saurabh-rahate commented Apr 2, 2023

I've identified more improvements to repository, but do not want to flood this PR and make it difficult to review.
Let me know if I should

  1. push those changes in this PR
    OR
  2. open multiple small PRs .

@yanglbme yanglbme merged commit ad72c28 into TheAlgorithms:master Apr 3, 2023
@siriak
Copy link
Copy Markdown
Member

siriak commented Apr 4, 2023

@saurabh-rahate, option 2, please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants