Skip to content

Fixed error in Palindrome.java and gave semantic names to functions - #3643

Merged
debasishbsws merged 8 commits into
TheAlgorithms:masterfrom
TaranjeetSinghKalsi:patch-1
Oct 27, 2022
Merged

Fixed error in Palindrome.java and gave semantic names to functions#3643
debasishbsws merged 8 commits into
TheAlgorithms:masterfrom
TaranjeetSinghKalsi:patch-1

Conversation

@TaranjeetSinghKalsi

Copy link
Copy Markdown
Contributor
  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

fixed error at line 57 and gave semantic names to functions with comments
renamed functions to match with original functions' names in the file
@TaranjeetSinghKalsi TaranjeetSinghKalsi changed the title fixed error and made gave names to functions with comments fixed error and gave semantic names to functions with comments Oct 24, 2022
@TaranjeetSinghKalsi TaranjeetSinghKalsi changed the title fixed error and gave semantic names to functions with comments Fixed error in Palindrome and gave semantic names to functions with comments Oct 24, 2022
@TaranjeetSinghKalsi TaranjeetSinghKalsi changed the title Fixed error in Palindrome and gave semantic names to functions with comments Fixed error in Palindrome.java and gave semantic names to functions Oct 25, 2022
Comment thread src/main/java/com/thealgorithms/strings/Palindrome.java Outdated
Comment thread src/main/java/com/thealgorithms/strings/Palindrome.java Outdated
Updated TestCases and changed a function name
Removed main() and changed the function name from isPalindromeStringBuilder to isPalindrome

@debasishbsws debasishbsws left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@debasishbsws
debasishbsws merged commit bd267bb into TheAlgorithms:master Oct 27, 2022
@TaranjeetSinghKalsi
TaranjeetSinghKalsi deleted the patch-1 branch October 29, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants