added impl for algorithm and base objects for algorithm#2574
Conversation
|
any changes and reviews are welcomed 😊 |
|
I'd appreciate a code review |
|
It's not a standard algorithm and I don't see where it can be used, so I don't think we should include it, thanks! |
|
@siriak it is used to find the tree node successor, its helpful in avl trees or when you need to find the node with the next greater key in the tree |
|
Then could you implement it with 'keys' and not points? Anything with a strict order would do. And please reuse the existing classes for trees and other |
|
the node key is represented by the point and the x value for each point is used to find the node successor |
|
Why do you need Point then? Just use Value instead of Point.X |
|
ok then, I'll replace it with a simple integer |
|
would you mind opening the PR so I can commit to it? |
transform usage from x, y point coordinates to plane integer values
|
all fixed and updated with the master branch |
siriak
left a comment
There was a problem hiding this comment.
Overall looks good, only some small changes needed
Sema Reaction: 👌 This code looks good
NRKTree - NearestRightKeyTree - the regular tree lacks functionality required for this algorithm to function, specifically in the inserting method
Describe your change:
closes add nearestRightKey algorithm #2573
Checklist:
Fixes: #{$ISSUE_NO}.