Skip to content

Add Strassen Matrix Multiplication algorithm#2490

Merged
siriak merged 7 commits into
TheAlgorithms:masterfrom
hoplite2k:master
Oct 6, 2021
Merged

Add Strassen Matrix Multiplication algorithm#2490
siriak merged 7 commits into
TheAlgorithms:masterfrom
hoplite2k:master

Conversation

@hoplite2k

Copy link
Copy Markdown
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

References

Fixes issue #2488

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@hoplite2k hoplite2k requested a review from siriak as a code owner October 5, 2021 13:45
@hoplite2k

Copy link
Copy Markdown
Contributor Author

Hello @siriak! Your review is much appreciated.

@siriak siriak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only one comment :)

Comment thread DivideAndConquer/StrassenMatrixMultiplication.java Outdated
Comment thread DivideAndConquer/StrassenMatrixMultiplication.java Outdated
@siriak

siriak commented Oct 6, 2021

Copy link
Copy Markdown
Member

Build is failing
./DivideAndConquer/StrassenMatrixMultiplication.java:4: error: class Strassen is public, should be declared in a file named Strassen.java
public class Strassen {

@hoplite2k

Copy link
Copy Markdown
Contributor Author

Hello @siriak! I have resolved the build failure. Can you please check
Thank you

@siriak siriak merged commit 6023b45 into TheAlgorithms:master Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants