Skip to content

Bulk Insert does not respect identity insert option #393

Open

Description

@jcwrequests

The best way to explain this is with code. The following works I can insert a value into an identity column

  using (var scope = new TransactionScope(TransactionScopeOption.Required, TimeSpan.FromSeconds(5 * 60)))
                        {
                            
                            foreach(var item in results)
                            {
                                Simple.Data.Database.
                                OpenConnection(destionationDBConnectionString).
                                WithOptions(new Simple.Data.Ado.AdoOptions(commandTimeout: (5 * 60), identityInsert: true))
                                [this.destinationTableName].Insert(item);
                            }
                            scope.Complete();
                        }

This does not. The table puts in the identity value:

     using (var scope = new TransactionScope(TransactionScopeOption.Required, TimeSpan.FromSeconds(5 * 60)))
                        

                            Simple.Data.Database.
                            OpenConnection(destionationDBConnectionString).
                            WithOptions(new Simple.Data.Ado.AdoOptions(commandTimeout: (5 * 60),identityInsert: true))
                            [this.destinationTableName].Insert(results);
                            scope.Complete();
                        }

I will try and examine the code and see if it can be fixed easily.

Activity

  1. jcwrequests commented on Jan 16, 2017

    @jcwrequests
    Author

    I have found the issue in the SqlBulkInserter and corrected it on a Forked version. While searching for the issue I noticed that the master branch version does not match the version on Nuget. The reason I even checked the version in the first place was the unchanged Forked code from master wasn't behaving the same as the code on Nuget. Does anyone know why this is the case?

  2. added a commit that references this issue on Jan 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions