Fix contextmenu not repositioning at bottom of screen on IE and contextmenus not closing on touch#146
Merged
Merged
Conversation
Fix contextmenu not closing on touch Fix case were no event got triggered to close a previous contextmenu, so we are clearing them before opening a new one
|
@Templarian can this PR please be approved? |
|
We need to use this improvement, is possible to approve this PR and make a release @Templarian ? That would make our life much easier. :) |
|
Could you @Templarian please release new version of this lib, so we can start use it out of the box ? Thank you very much for the effort one again. |
Collaborator
|
@berc v1.2.1 is released. Sorry for the delay |
Owner
|
@josetaira You're awesome! Thanks. |
|
Guys @Templarian @josetaira, that is amazing. Thank you very much! |
Contributor
Author
|
Thx for merging it guys |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix contextmenu not closing on touch
Fix case were no event got triggered to close a previous contextmenu, so we are clearing them before opening a new one