Refactor deprecated prepublish to prepack#26
Merged
winsmith merged 1 commit intoTelemetryDeck:mainfrom Nov 30, 2023
Merged
Conversation
Collaborator
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
It seemed that my last change wasn't published, so I thought that the
prepublishscript didn't run before the publish of the last package. I did some research together with @pichfl and found out theprebublishlifecycle is deprecated and does not run beforepublishbut afterinstallorci.What I changed
After a quick chat with @pichfl we agreed that the
prepacklifecycle hook (another option would beprepublishOnly) should do the magic (cf. npm docs), so I changed the script from prepublish to prepack.