Skip to content

Take care of push calls that happen after TD was loaded #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
winsmith wants to merge 1 commit into from
Closed

Take care of push calls that happen after TD was loaded #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/telemetrydeck.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ export class TelemetryDeck {
*
* @returns {Promise<void>}
*/
push([method, data] = []) {
return this[method](data);
push() {
return this.ingest(Array.from(arguments));
}

/**
Expand Down
33 changes: 33 additions & 0 deletions tests/telemetrydeck.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,39 @@ describe('TelemetryDeck.signal()', () => {
});
});

test('sends signal to TelemetryDeck after TD was loaded', async () => {
window.location.href = 'https://nasa.gov';

const spy = jest.spyOn(window, 'fetch');
const td = new TelemetryDeck();
await td.push(['app', 'foo'], ['user', 'bar'], ['signal']);

expect(spy).toHaveBeenCalledTimes(1);
expect(spy).toHaveBeenCalledWith('https://nom.telemetrydeck.com/v1/', {
body: JSON.stringify([
{
appID: 'foo',
clientUser: 'fcde2b2edba56bf408601fb721fe9b5c338d10ee429ea04fae5511b68fbf8fb9',
sessionID: 'fcde2b2edba56bf408601fb721fe9b5c338d10ee429ea04fae5511b68fbf8fb9',
type: 'pageview',
payload: [
`url:${location.href}`,
`useragent:${navigator.userAgent}`,
`locale:${navigator.language}`,
`platform:${navigator.userAgentData ?? ''}`,
`vendor:${navigator.vendor}`,
`telemetryClientVersion:JavaScriptSDK ${version}`,
],
},
]),
headers: {
'Content-Type': 'application/json',
},
method: 'POST',
mode: 'cors',
});
});

test('sends signals to TelemetryDeck with additional payload data', async () => {
const spy = jest.spyOn(window, 'fetch');
const queue = [['app', 'foo'], ['user', 'bar'], ['signal'], ['signal', { baz: 'bat' }]];
Expand Down