Path parameters as function positional arguments - #1
Closed
tsotnikov wants to merge 5 commits into
Closed
Conversation
own3dh2so4
approved these changes
May 17, 2021
OpenAPI Specification indicates that if parameter location is `path` the `required` property is REQUIRED and its value MUST be `true` Ref: https://github.com/OAI/OpenAPI-Specification/blob/main/versions/3.1.0.md#parameter-object With this in mind, this PR: - Tighten the parsing by throwing an error for path parameters with required=false - Update the templates to pass the path parameters to the function as positional arguments instead of kwargs to improve usability
tsotnikov
force-pushed
the
path-parameters-args
branch
from
May 17, 2021 13:26
c819d65 to
fd5629f
Compare
dpaneda
approved these changes
May 24, 2021
Also fix typo Co-authored-by: Dylan Anthony <43723790+dbanty@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenAPI Specification indicates that if parameter location is
paththe
requiredproperty is REQUIRED and its value MUST betrueRef: https://github.com/OAI/OpenAPI-Specification/blob/main/versions/3.1.0.md#parameter-object
With this in mind, this PR:
to improve usability