Skip to content
This repository was archived by the owner on Nov 15, 2024. It is now read-only.

Add fallback to ide redirect when browser detection fails #450

Merged
purplexa merged 1 commit into from
Jun 3, 2024
Merged

Add fallback to ide redirect when browser detection fails #450

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions api_server/modules/apiweb/templates/partial_launcher_detailed.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,10 @@
successCb && successCb();
}

function unsupportedCallback() {
unsupportedCb && unsupportedCb();
}

if (navigator.msLaunchUri) { //for IE and Edge in Win 8 and Win 10
openUriWithMsLaunchUri(uri, failCb, successCb);
} else {
Expand All @@ -276,8 +280,9 @@
} else if (browser.isSafari) {
openUriWithHiddenFrame(uri, failCallback, successCallback);
} else {
unsupportedCb();
//not supported, implement please
unsupportedCallback();
// this works for most common browsers, so we try it if detection fails
openUriWithTimeoutHack(uri, failCallback, successCallback);
}
}
}
Expand Down