Skip to content

[SPM] Adds SPM support#825

Open
vijaytholpadi wants to merge 12 commits into
TTTAttributedLabel:masterfrom
carousell:feature/spm-support
Open

[SPM] Adds SPM support#825
vijaytholpadi wants to merge 12 commits into
TTTAttributedLabel:masterfrom
carousell:feature/spm-support

Conversation

@vijaytholpadi
Copy link
Copy Markdown

@vijaytholpadi vijaytholpadi commented Jun 24, 2024

This PR adds SPM support to the PR.

It also fixes the following:

  • Example app
    • Updates min iOS version to 12
    • Updates KIF dependency due to issue with Xcode 12+
    • Updates recorded Snapshot as the device previously used is no longer available
    • Updates Podfile to use the CDN for specs
  • Migrates CircleCI workflow to version 2.0 and fixes the configuration to get the CI up and running

@vijaytholpadi
Copy link
Copy Markdown
Author

@taimoorsuleman Can we merge this PR? I see that it is blocked on the CircleCI configuration issue.

@vijaytholpadi
Copy link
Copy Markdown
Author

vijaytholpadi commented Aug 22, 2024

Any one know who has access to this repository's settings to disable the older ci/circleci check and only keep the new one?

I added SPM support and also fixed the CI and the tests in this PR. But am blocked on this deprecated check to merge this change.

Any help would be greatly appreciated! cc @segiddins @rickharrison @jessesquires @dillan 🙇

@ankit0812
Copy link
Copy Markdown

@mattt @jhersh @segiddins @rickharrison @dillan

Any help here?

@ykhandelwal913
Copy link
Copy Markdown

@segiddins @mattt can you review and merge if all good?

@sebGuerrero
Copy link
Copy Markdown

Hey, also interested into getting this merged, just asked to give some support to migrate an old codebase to SPM and this is the only package I've got left to migrate.

@ankit0812
Copy link
Copy Markdown

@ykhandelwal913 @sebGuerrero

Just wanted to add my opinion here. This is only a 2 file Objective C code one .h and .m file each.
Just import to your package or product, use a bridging header and you are sorted. I was also stuck during my SPM migration and followed this path and was out of this issue.

Let me know if you need any help.

@Zavalynech
Copy link
Copy Markdown

N

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants