remove warning + update xcodeproj to recommended settings#631
Open
AndrewSB wants to merge 2 commits into
Open
Conversation
Current coverage is
|
Member
|
@AndrewSB if you rebase this, the tests should pass. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've removed an if check that was seeing if there was a pointer to
NSLinkAttributeName. This will always succeed (in this project) because the deployment target is ios 8.0, and NSLinkAttributeName is marked available since ios 7.This may have failed previously, but through using a framework it will not, so I think it's safe to remove -- it's also a warning while building the framework.
I also went ahead and update the xcodeproj in
Carthage/to Apple's recommended settings