fix: prevent build zip artifacts from leaking into main#15
Merged
Conversation
Closes DTD#55. Adds *.zip to .gitignore and removes the two existing zip artifacts (unity-developer-tools-v1.4.3.zip, unity-developer-tools-v1.4.4.zip) that landed in main after the DTD#51 fix flipped release.yml's bump-commit step from selective `git add` to `git add -A`. The selective add was incidentally protecting main from the zip artifact created by the Build plugin zip step; the structural fix is the .gitignore rule, which makes the artifact invisible to git regardless of the git add shape used. Release assets continue to receive the zip via softprops/action-gh-release@v2 as before. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the regression where Unity's release pipeline leaks the build zip into main on every release.
What changed
*.zipto .gitignoreunity-developer-tools-v1.4.3.zipandunity-developer-tools-v1.4.4.zipfrom main (the two artifacts that landed since DTD#51)Root cause
DTD#51 fix flipped the bump-commit step from selective
git add(which incidentally excluded the zip) togit add -A(which stages everything in the working tree, including the zip). The .gitignore rule is the structural fix that eliminates the latent coupling permanently.Verification
After merge, the next Unity release should:
git add -A)CFX-Developer-Tools is unaffected (no zip-build step in CFX's release.yml).
Closes TMHSDigital/Developer-Tools-Directory#55.