Skip to content

[LIB-660][HOTFIX] Push send message and configs #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
opalczynski merged 13 commits into from
Apr 21, 2016
Merged

[LIB-660][HOTFIX] Push send message and configs #190

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
0d77738
[LIB-660] Add possibility to edit Device, add send_message method;
opalczynski Apr 21, 2016
efa19b7
[LIB-660] correct test a litle
opalczynski Apr 21, 2016
875a519
[LIB-660] correct test a litle
opalczynski Apr 21, 2016
0fd2b35
[LIB-660] add config for apns and gcm - correct test; lets build it :)
opalczynski Apr 21, 2016
93a7e5f
[LIB-660] correct setup test
opalczynski Apr 21, 2016
432574b
[LIB-660] correct setup test
opalczynski Apr 21, 2016
f171f04
[LIB-660] correct typo
opalczynski Apr 21, 2016
16e1f84
[LIB-660] correct typo
opalczynski Apr 21, 2016
2f2177c
[LIB-660] correct cert path
opalczynski Apr 21, 2016
8303c16
[LIB-660] test fixes
opalczynski Apr 21, 2016
58a3119
[LIB-660] test fixes
opalczynski Apr 21, 2016
6700871
[LIB-660] add binary mode to read file
opalczynski Apr 21, 2016
68bc102
[LIB-660] correct comment
opalczynski Apr 21, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[LIB-660] add binary mode to read file
  • Loading branch information
@opalczynski
opalczynski committed Apr 21, 2016
commit 670087186c8b500b447e9f20f5652b4d3ac68612
2 changes: 1 addition & 1 deletion syncano/connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,7 @@ def get_user_info(self, api_key=None, user_key=None):

def _process_apns_cert_files(self, files):
files = files.copy()
for key in files.keys():
for key in [file_name for file_name in files.keys()]:
# remove certificates files (which are bool - True if cert exist, False otherwise)
value = files[key]
if isinstance(value, bool):
Expand Down
2 changes: 1 addition & 1 deletion tests/integration_test_push.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ def setUpClass(cls):
)
cls.gcm_config.save()

with open('tests/certificates/ApplePushDevelopment.p12', 'r') as cert:
with open('tests/certificates/ApplePushDevelopment.p12', 'rb') as cert:
cls.apns_config = APNSConfig(
development_certificate=cert,
development_certificate_name='test',
Expand Down