Conversation
mkucharz
requested changes
Feb 13, 2018
|
|
||
| ### Problem to solve | ||
|
|
||
| You want to upload file to the server |
Member
There was a problem hiding this comment.
Missing dot. Maybe we should call it more precise "you want to upload file to database"?
|
|
||
|
|
||
| #### Prepare socket | ||
|
|
Member
There was a problem hiding this comment.
Maybe we should have it more direct like:
- create socket
s create test123 - edit
socket.yml - add form-data dependency
npm install --save ...
I'm a little bit concerned that newbies might be lost somewhere on the way...
|
|
||
| ``` | ||
|
|
||
|
|
|
|
||
|
|
||
|
|
||
| #### Create client side code |
|
|
||
| #### Create client side code | ||
|
|
||
| Let's assume that you have a simple form in html |
|
|
||
| ``` | ||
|
|
||
| After submitting the file, data object will store link to your file hosted on cloudfront. File size limit is 128 MB. No newline at end of file |
Member
There was a problem hiding this comment.
File is hosted on "S3" behind the "CloudFront" - I'm only not sure if it is relevant for the end user. Upload limit to the script is 6MB. Limit for file upload from inside the Socket script is 128MB.
Codecov Report
@@ Coverage Diff @@
## master #143 +/- ##
==========================================
- Coverage 34.73% 28.66% -6.08%
==========================================
Files 118 102 -16
Lines 4623 2864 -1759
==========================================
- Hits 1606 821 -785
+ Misses 3017 2043 -974 |
Member
Author
|
@mkucharz - updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.