Raised a 'invalidJSON' error if initialization JSON data is corrupt.#1052
Open
VarmeLin wants to merge 1 commit intoSwiftyJSON:masterfrom
VarmeLin:damage-inspection
Open
Raised a 'invalidJSON' error if initialization JSON data is corrupt.#1052VarmeLin wants to merge 1 commit intoSwiftyJSON:masterfrom VarmeLin:damage-inspection
VarmeLin wants to merge 1 commit intoSwiftyJSON:masterfrom
VarmeLin:damage-inspection
Conversation
luoxiu
approved these changes
Jul 16, 2021
Naveen-C-Ramachandrappa
approved these changes
Jul 16, 2024
Naveen-C-Ramachandrappa
left a comment
There was a problem hiding this comment.
Makes complete sense to have this change to account for invalid json.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think you should tell the upper layer of the corrupted JSON data error. And the meaning of ‘null' and corruption is different in JSON, we better distinguish.
What behavior was changed?
Set the error parameter to '.invalidJSON' when JSON parsing was failed.
What is the application scenario?
I need to check the correctness of the JSON file returned from the remote, or I need to check the
correctness of the JSON file passed in by the upper layer.