Skip to content

SONARJAVA-6661 small refactoring#5830

Draft
dorian-burihabwa-sonarsource wants to merge 2 commits into
masterfrom
db/SONARJAVA-6661
Draft

SONARJAVA-6661 small refactoring#5830
dorian-burihabwa-sonarsource wants to merge 2 commits into
masterfrom
db/SONARJAVA-6661

Conversation

@dorian-burihabwa-sonarsource

@dorian-burihabwa-sonarsource dorian-burihabwa-sonarsource commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Summary by Gitar

  • Test modifications:
    • Commented out several integration tests in JavaRulingTest.java to skip them during execution.
    • Refactored guava test to use a list for Maven goals instead of inline configuration.
    • Updated guava test property sonar.java.source to 17 to ensure correct Java source version for analysis.

This will update automatically on new commits.

@hashicorp-vault-sonar-prod

hashicorp-vault-sonar-prod Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

SONARJAVA-6661

Comment thread its/ruling/src/test/java/org/sonar/java/it/JavaRulingTest.java Outdated
@dorian-burihabwa-sonarsource
dorian-burihabwa-sonarsource changed the base branch from codex/fix-guava-ruling-java-version to master July 22, 2026 12:41
@gitar-bot

gitar-bot Bot commented Jul 22, 2026

Copy link
Copy Markdown
Code Review ✅ Approved 1 resolved / 1 findings

Refactors the Guava test to use a cleaner list-based configuration for Maven goals. Commented-out integration tests in JavaRulingTest have been resolved.

✅ 1 resolved
Bug: Multiple ruling @test annotations commented out, disabling tests

📄 its/ruling/src/test/java/org/sonar/java/it/JavaRulingTest.java:192 📄 its/ruling/src/test/java/org/sonar/java/it/JavaRulingTest.java:222 📄 its/ruling/src/test/java/org/sonar/java/it/JavaRulingTest.java:234 📄 its/ruling/src/test/java/org/sonar/java/it/JavaRulingTest.java:353 📄 its/ruling/src/test/java/org/sonar/java/it/JavaRulingTest.java:362 📄 its/ruling/src/test/java/org/sonar/java/it/JavaRulingTest.java:381 📄 its/ruling/src/test/java/org/sonar/java/it/JavaRulingTest.java:392
Seven test methods (spring_mall, apache_commons_beanutils, eclipse_jetty_incremental, sonarqube_server, jboss_ejb3_tutorial, regex_examples, vibebot) have their @test annotation commented out, so JUnit no longer runs them and the ruling coverage silently drops to essentially just guava(). This looks like a local debugging shortcut to iterate on the guava test; restore the @test annotations before merging so the full ruling suite continues to run in CI.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqube-next

Copy link
Copy Markdown

@dorian-burihabwa-sonarsource
dorian-burihabwa-sonarsource changed the base branch from master to codex/fix-guava-ruling-java-version July 22, 2026 13:05
Base automatically changed from codex/fix-guava-ruling-java-version to master July 22, 2026 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants