You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR updates rule S2092 (secure cookie flag) metadata to align with current SonarSource standards:
Key changes:
Rule classification: Changed from SECURITY_HOTSPOT to VULNERABILITY in the JSON metadata
Documentation restructure: Converted rule description HTML from legacy format (Ask Yourself Whether / Recommended Practices) to modern format (Why is this an issue? / Potential impact / How to fix it)
Content improvements: Added detailed explanation of session hijacking risks, improved code examples with diff markup (data-diff-id/data-diff-type), and changed terminology from "Sensitive Code Example" to "Noncompliant code example" to match current conventions
Title refinement: Simplified rule title from "Creating cookies without the "secure" flag is security-sensitive" to "Cookies should have the "secure" flag"
Metadata cleanup: JSON formatting adjustment and timestamp update
The changes modernize the rule presentation without altering the core detection logic or severity assessment.
What reviewers should know
What to review:
Type change impact: The S2092 rule type changed from SECURITY_HOTSPOT to VULNERABILITY. Verify this classification change is intentional and doesn't affect how the rule is processed by SonarQube.
HTML documentation: Check that the restructured rule description is clearer and the new format (with diff markup in code examples) renders correctly in SonarQube.
Breaking changes: Confirm that changing from SECURITY_HOTSPOT to VULNERABILITY doesn't break any existing integrations, dashboards, or rule filtering logic that depends on the old type.
Metadata consistency: The JSON formatting moves quickfix earlier in the structure—verify this doesn't affect parsing or tooling that depends on JSON field order.
No logic changes—this is purely metadata and documentation updates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.