Skip to content

SONARJAVA-6123 Issues for rule S8433#5463

Merged
asya-vorobeva merged 2 commits into
masterfrom
asya/s8433-fix
Feb 16, 2026
Merged

SONARJAVA-6123 Issues for rule S8433#5463
asya-vorobeva merged 2 commits into
masterfrom
asya/s8433-fix

Conversation

@asya-vorobeva
Copy link
Copy Markdown
Contributor

@asya-vorobeva asya-vorobeva commented Feb 16, 2026

Added fix for the rule S8433 to raise issues only when explicit constructor call is present.

@hashicorp-vault-sonar-prod
Copy link
Copy Markdown
Contributor

hashicorp-vault-sonar-prod Bot commented Feb 16, 2026 •
edited by atlassian Bot
Loading

SONARJAVA-6123

rombirli
rombirli reviewed Feb 16, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@rombirli rombirli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change in the code looks good to me, but I'd suggest testing it (constructorCallIndex == -1 is always false)

Comment thread ...efault/src/main/files/non-compiling/checks/FlexibleConstructorBodyValidationCheckSample.java
@asya-vorobeva
Copy link
Copy Markdown
Contributor Author

asya-vorobeva commented Feb 16, 2026

The change in the code looks good to me, but I'd suggest testing it (constructorCallIndex == -1 is always false)

Sorry? constructorCallIndex == -1 iff we haven't explicit constructor call. As I've said we fix it in our sample (l.136)

@rombirli
Copy link
Copy Markdown
Contributor

rombirli commented Feb 16, 2026

Sorry? constructorCallIndex == -1 iff we haven't explicit constructor call. As I've said we fix it in our sample (l.136)

Ah my bad I didn't see this sample, LGTM then

rombirli
rombirli approved these changes Feb 16, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@rombirli rombirli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asya-vorobeva asya-vorobeva enabled auto-merge (squash) February 16, 2026 10:52
@sonarqube-next
Copy link
Copy Markdown

sonarqube-next Bot commented Feb 16, 2026

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@hashicorp-vault-sonar-prod
Copy link
Copy Markdown
Contributor

hashicorp-vault-sonar-prod Bot commented Feb 16, 2026

The target branch was unlocked and auto-merge was canceled to prevent unexpected actions.

@asya-vorobeva asya-vorobeva merged commit 9444b20 into master Feb 16, 2026
17 checks passed
@asya-vorobeva asya-vorobeva deleted the asya/s8433-fix branch February 16, 2026 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rombirli rombirli rombirli approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@asya-vorobeva @rombirli