Skip to content

SONARJAVA-5400 Fix false positive for S6241 and S6242 when builder is not AwsClientBuilder#5104

Merged
romainbrenguier merged 2 commits into
masterfrom
romain/s3-client-builder
Apr 29, 2025
Merged

SONARJAVA-5400 Fix false positive for S6241 and S6242 when builder is not AwsClientBuilder#5104
romainbrenguier merged 2 commits into
masterfrom
romain/s3-client-builder

Conversation

@romainbrenguier

@romainbrenguier romainbrenguier commented Apr 28, 2025

Copy link
Copy Markdown
Contributor

SONARJAVA-5400

Previously these checks were only taking account calls on some specific kind of builders, but there can be other implementations.

…ider

Previously this was only taking account calls on some specific kind of builders, but there can be other implementations.
Showing a case that was previously a false positive.
@sonarqube-next

Copy link
Copy Markdown

@erwan-serandour erwan-serandour left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romainbrenguier romainbrenguier marked this pull request as ready for review April 29, 2025 09:35
@romainbrenguier romainbrenguier merged commit ff76a4e into master Apr 29, 2025
@romainbrenguier romainbrenguier deleted the romain/s3-client-builder branch April 29, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants