Skip to content

ECHOES-1268 Fix flaky tests#660

Merged
jeremy-davis-sonarsource merged 1 commit into
mainfrom
jay/fix-flaky-tests
Mar 24, 2026
Merged

ECHOES-1268 Fix flaky tests#660
jeremy-davis-sonarsource merged 1 commit into
mainfrom
jay/fix-flaky-tests

Conversation

@jeremy-davis-sonarsource
Copy link
Copy Markdown
Contributor

No description provided.

@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 24, 2026

Deploy Preview for echoes-react ready!

Name Link
🔨 Latest commit f373230
🔍 Latest deploy log https://app.netlify.com/projects/echoes-react/deploys/69c28fc443d319000816f45d
😎 Deploy Preview https://deploy-preview-660--echoes-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sonar-review-alpha
Copy link
Copy Markdown

sonar-review-alpha Bot commented Mar 24, 2026

Summary

Extracted the TOOLTIP_DELAY_IN_MS constant into a shared utils module so that tests can mock it to 0ms, eliminating 1-second delays during test execution. The production code still uses the 1000ms delay, but tests now run instantly without timing-related flakiness.

What reviewers should know

Start by looking at the new utils.ts file to see the constant being extracted. Then review the two component files to confirm the import change is consistent. The test files show the key fix: they now mock the utils module to set the delay to 0, which removes the timing dependency that was causing flaky tests. No behavior changes in production code.


  • Generate Walkthrough
  • Generate Diagram

🗣️ Give feedback

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod Bot changed the title Fix flaky tests ECHOES-1268 Fix flaky tests Mar 24, 2026
@hashicorp-vault-sonar-prod
Copy link
Copy Markdown

hashicorp-vault-sonar-prod Bot commented Mar 24, 2026

ECHOES-1268

@sonarqube-next
Copy link
Copy Markdown

@jeremy-davis-sonarsource jeremy-davis-sonarsource merged commit 3ce92b2 into main Mar 24, 2026
11 of 12 checks passed
@jeremy-davis-sonarsource jeremy-davis-sonarsource deleted the jay/fix-flaky-tests branch March 24, 2026 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants