Skip to content

PREQ-3425 use ci-github-actions v1 (1.3.19)#606

Merged
jeremy-davis-sonarsource merged 1 commit into
mainfrom
fix/jcarsique/PREQ-3425-lockfile
Jan 19, 2026
Merged

PREQ-3425 use ci-github-actions v1 (1.3.19)#606
jeremy-davis-sonarsource merged 1 commit into
mainfrom
fix/jcarsique/PREQ-3425-lockfile

Conversation

@julien-carsique-sonarsource
Copy link
Copy Markdown
Contributor

@julien-carsique-sonarsource julien-carsique-sonarsource commented Jan 19, 2026

PREQ-3425
Depends on SonarSource/ci-github-actions#199

  • use ci-github-actions v1 (1.3.19)
  • update lockfile

@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 19, 2026

Deploy Preview for echoes-react ready!

Name Link
🔨 Latest commit 7ab15d6
🔍 Latest deploy log https://app.netlify.com/projects/echoes-react/deploys/696e128d20461f00087dea6b
😎 Deploy Preview https://deploy-preview-606--echoes-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@hashicorp-vault-sonar-prod
Copy link
Copy Markdown

hashicorp-vault-sonar-prod Bot commented Jan 19, 2026

PREQ-3425

@jeremy-davis-sonarsource
Copy link
Copy Markdown
Contributor

We shouldn't need to touch the lockfile.
I'm pretty sure that's why all the tests are broken

@julien-carsique-sonarsource julien-carsique-sonarsource force-pushed the fix/jcarsique/PREQ-3425-lockfile branch from 3a4dc21 to 81aee5e Compare January 19, 2026 10:54
@julien-carsique-sonarsource
Copy link
Copy Markdown
Contributor Author

@jeremy-davis-sonarsource confirmed. I'm removing the lock file change.
The issue was:

  • authentication overwrites the local .yarnrc.yml
  • this invalidates the current lockfile
    So, everything (lockfile and tests) will be resolved with the improvement on the authtentication.

@julien-carsique-sonarsource julien-carsique-sonarsource force-pushed the fix/jcarsique/PREQ-3425-lockfile branch from 18debe0 to 7ab15d6 Compare January 19, 2026 11:16
@julien-carsique-sonarsource julien-carsique-sonarsource changed the title PREQ-3425 use ci-github-actions v1 (1.3.18) PREQ-3425 use ci-github-actions v1 (1.3.19) Jan 19, 2026
@julien-carsique-sonarsource julien-carsique-sonarsource marked this pull request as ready for review January 19, 2026 11:18
@sonarqube-next
Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link
Copy Markdown
Contributor

@jeremy-davis-sonarsource jeremy-davis-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@jeremy-davis-sonarsource jeremy-davis-sonarsource merged commit 66e3402 into main Jan 19, 2026
9 checks passed
@jeremy-davis-sonarsource jeremy-davis-sonarsource deleted the fix/jcarsique/PREQ-3425-lockfile branch January 19, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants