JS-1838 Add selector-anb-no-unmatchable CSS rule#7204
Draft
erwan-leforestier-sonarsource wants to merge 1 commit into
Draft
JS-1838 Add selector-anb-no-unmatchable CSS rule#7204erwan-leforestier-sonarsource wants to merge 1 commit into
erwan-leforestier-sonarsource wants to merge 1 commit into
Conversation
|
Code Review ✅ ApprovedImplements the selector-anb-no-unmatchable CSS rule to detect invalid formulas like :nth-child(0), including comprehensive analyzer tests and profile updates. No issues found. OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the CSS stylelint-backed rule that reports unmatchable An+B selectors such as
:nth-child(0).RSPEC PR: https://github.com/SonarSource/rspec/pull/7032
Changes
selector-anb-no-unmatchableFunctional Validation
Artifact:
JS-1838-fv.zipOnce the file is attached to the PR description, unzip and run:
./run.sh
Expected output is in
expected-output.txt. The README shows thebefore/after comparison so you can reproduce the difference directly.